fix(sdk): identify workspace dependencies by version specifier - #45309
Merged
Conversation
kitlangton
enabled auto-merge (squash)
August 26, 2026 16:54
kitlangton
disabled auto-merge
August 26, 2026 16:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The packed workerd SDK check fails with
@opencode-ai/core has unpacked workspace dependencies: @opencode-ai/pty, including in the CI run investigated during #45292. Since #45248, Core depends on the published@opencode-ai/pty@0.1.9package, but the verifier assumes every dependency in the@opencode-aiscope belongs to this workspace.What Changes
Identify dependencies that require a local archive by their
workspace:version specifier instead of their package-name scope.@opencode-ai/pty: 0.1.9@opencode-ai/schema: workspace:*, already packed@opencode-ai/schema: workspace:*, not yet packedScope
Only changes dependency classification in the SDK package-verification script. No package-specific exception or runtime/API change; this is separate from the TUI selection fix in #45292.
Verification
@opencode-ai/ptyfailure with the original verifier onf4a9b93013.packed SDK consumer OK).protocolbeforeschemain the packing order and reran the real verifier. It still rejected the missing archive with@opencode-ai/protocol has unpacked workspace dependencies: @opencode-ai/schema; restored the original order before the passing run.